Rework pool tests to use real chain (was mock chain) #3342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t reality (tx/block validation rules etc.)
antiochp
changed the title
19 tasks
|
Going to merge this now so it does not block #3302. @quentinlesceller please continue to review and we can address any feedback separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the existing pool tests to setup and use a real chain instance.
We were mocking the chain out previously.
This was introducing some inconsistencies in the chain block and tx validation rules.
This required reworking the
block_weighttests to useAutomatedTestingchain type rather thanMainnet.Changes in this PR are limited in scope to test code only.
The only exception to this is an increase to the
global::TESTING_MAX_BLOCK_WEIGHTto allow the block_weight tests to be run againstAutomatedTesting.This is refactoring required to test the NRD lock height rules (separate PR) so we can effectively test the rules without needing to mock them up in chain.